Skip to content

Introduction of support to TTML#15

Draft
alexandercerutti wants to merge 766 commits intodevelopfrom
feature/ttml-adapter
Draft

Introduction of support to TTML#15
alexandercerutti wants to merge 766 commits intodevelopfrom
feature/ttml-adapter

Conversation

@alexandercerutti
Copy link
Copy Markdown
Owner

@alexandercerutti alexandercerutti commented Feb 18, 2024 •
edited
Loading

Breaking changes

  • (Re)Introduced Entities.Style;
  • Removed Entities.Tag.setStyles;
  • Removed the concepts of offset and length in lines;
  • (Behavior) Adapters now are in charge of specifing the entities to apply to specific cues, in a ordered way (captions-renderer won't re-order them anymore)

Todo list

  • Add meaningful error classes instead of generic throw new Error()

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sub37-sample Ready Ready Preview, Comment Apr 1, 2026 11:23pm

@alexandercerutti alexandercerutti linked an issue Feb 18, 2024 that may be closed by this pull request
Multi line does not preserve style #11
Closed
@alexandercerutti alexandercerutti changed the title Introduction of support to TTML Adapter Introduction of support to TTML Feb 18, 2024
@alexandercerutti alexandercerutti self-assigned this Feb 24, 2024
@alexandercerutti
Improved isInlineAnimation in order to check differently if an elemen…
1f803e6 
…t supports animate attribute. This plays on the fact that any element that supports animate attribute actually supports Animation.class*
@alexandercerutti
Fixed type for animation fill
293a4f3
@alexandercerutti
Added Animation Styles CSS conversion
576b38b
@alexandercerutti
Added animation temporal segments generation and association with cues
5b07507
@alexandercerutti
Added UniquelyAnnotatedNode to classify nodes that contain xml:id and…
5b53e9e 
… type them
@alexandercerutti
Refactored createStyleContainerContext to accept an array of styles o…
4c64f7f 
…bjects
@alexandercerutti
Preparing to remove the style memoizationFactory to made it easier to…
a2d0018 
… process and store the style directly in the context
@alexandercerutti
Added region xml:id check on attach and merge of contexts
2159e5c
@alexandercerutti
Dismantled parseRegion and merged it inside RegionContainerContext
91d8b59
@alexandercerutti
Removed parseStyle from RegionContainerContext for a subscope that pr…
081df0b 
…ocesses styles on its own, according to StyleContainerContext logic
@alexandercerutti
Improved reusage of region creation logic
a7d2df1
@alexandercerutti
Dismantled completely style parser
a1ee509
@alexandercerutti
Merge branch 'develop' into feature/ttml-adapter
864bc6a
@alexandercerutti
Refactored animations in order to ditch memoizationFactory from that …
b26961a 
…and switch to a calcMode factory system; removed parseAnimation as now everything happens in the AnimationContainerContext
@alexandercerutti
Completely dismantled memoizationFactory
4c6babc
@alexandercerutti
Fixed import path
4c82da5
@alexandercerutti
Removed styles attributes preprocessing before being fed to the Style…
7c2e539 
… context
@alexandercerutti
Changed styles resolution in order to keep in consideration previousl…
79d4977 
…y not considered rules and criteria. Added chain referential styles resolution based on typology and removed Style IDREFs renames when clashing
@alexandercerutti
Changed order of functions
53b678c
@alexandercerutti
Improved readability
5b79c63
@alexandercerutti
Added RegionContainerContext method getAnimationsByRegionId, animatio…
92a6016 
…n getter in the TTMLRegion, split code regions and renamed parameters for coherence
@alexandercerutti
Added check to prevent inline regions to be found when we are in an r…
688cdaa 
…egion
@alexandercerutti
Added check on extraction of multiple idref while parsing animate att…
6b4999d 
…ribute
@alexandercerutti
Changed BYO Region protocol to have entities applied exclusively to t…
413968d 
…he region element
@alexandercerutti
Added ttml-adapter to sample
30d50c4
@alexandercerutti
Removed ActiveStyle, added kind directly to TTMLStyle, uniformed wher…
8397f8d 
…e kind is applied and fixed kind filtering which was preventing styled being applied
@alexandercerutti
Fixed TTMLStyle not being generated because 'xml:id' was getting chec…
f072b47 
…ked among style attributes
@alexandercerutti
Added StyleContextContainer styles getter to retrieve all instead of …
6e27a21 
…looking for inline and nested (they were looked as they were IDSs)
@alexandercerutti
Added ignore warnings and removed useless wrapping function shouldIgn…
87576c0 
…oreOutOfLineRegion
@alexandercerutti
Fixed CueNodes composition by changing how the nodes get splitted
6320dac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@alexandercerutti alexandercerutti

Labels

💥 Breaking Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Multi line does not preserve style

1 participant

@alexandercerutti