Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了两处。
异常处理
当一个规则如
"URIXXX": { "value": "\\.(git|svn)", "operator": "≈" }时，由于没有对URIXXX的处理，所以永远都会return true，所以添加了一个对这个场景的异常处理。当然，如果通过dashboard不会存在这个问题，不过我最近在使用的时候，改了dashboard，升级后遇到了这个bug，所以提交了这个PR。
!操作符还有一个问题是，操作符
!感叹号，根本用不到这个操作符，但是代码里还有，所以删除了该段代码。如果这个操作符有特殊用处，麻烦回复一下。我翻了代码没有发现有在使用。