Conversation
To make maintenance of this project easier a rewrite is badly needed. Previous code lacks clarity and tightly-coupled. In this change a better introduced: * Clean stages: Load, Verify, Format. * Separate types that are not coupled. Certificate, Report, and Formatter handle their own parts. * Simpler output without unnecessary fanciness of lipgloss library. The output format has changed but I believe it's for good: less emojis, less colors. Just a straightforward output with a touch of color for status. Tests and golden files were updated accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make maintenance of this project easier a rewrite is badly needed. Previous code lacks clarity and tightly-coupled. In this change a better introduced:
The output format has changed but I believe it's for good: less emojis, less colors. Just a straightforward output with a touch of color for status. Tests and golden files were updated accordingly.