Merged
Conversation
Problem: the automerge-repo JS implementation saves sync states of remote peers in local storage in order to speed up initial sync with previously connected peers. The sync state is saved if the initial join message from a peer contains a `peerMetadata` field with `isEphemeral: false` and a storage ID. We currently encode the peer metadata in the join message under the wrong key, which causes the JS implementation to ignore it and not save the sync state. Solution: encode the peer metadata under the correct key in the join message
alexjg
force-pushed
the
fix-join-message
branch
from
4548525 to
addd778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the automerge-repo JS implementation saves sync states of
remote peers in local storage in order to speed up initial sync with
previously connected peers. The sync state is saved if the initial join
message from a peer contains a
peerMetadatafield withisEphemeral: falseand a storage ID. We currently encode the peer metadata in thejoin message under the wrong key, which causes the JS implementation to
ignore it and not save the sync state.
Solution: encode the peer metadata under the correct key in the join
message