Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
SidxBoxstructure to themp4boxmodule. The main changes include adding the new module, defining theSidxBoxandSegmentstructures, and implementing necessary traits for reading, writing, and serializing theSidxBox.New Feature:
SidxBoxImplementationModule Addition:
pub(crate) mod sidx;tosrc/mp4box/mod.rs.pub use sidx::SidxBox;tosrc/mp4box/mod.rs.SidxBoxto theboxtype!macro insrc/mp4box/mod.rs.SidxBoxStructure:SidxBoxstructure with fields such asversion,flags,reference_id,timescale,earliest_presentation_time,first_offset,reserved,reference_count, andsegments.Mp4Box,Default,ReadBox, andWriteBoxtraits forSidxBox.SegmentStructure:Segmentstructure with fields such asreference_type,reference_size,subsegment_duration,starts_with_sap,sap_type, andsap_delta_time.Segmentinstances.Tests:
SidxBoxwith both version 0 and version 1 formats to ensure correct serialization and deserialization.