Skip to content

feat(execd): trust mitm proxy by default#630

Open
Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Pangjiping:feat/execd/mitmproxy
Open

feat(execd): trust mitm proxy by default#630
Pangjiping wants to merge 1 commit intoalibaba:mainfrom
Pangjiping:feat/execd/mitmproxy

Conversation

@Pangjiping
Copy link
Copy Markdown
Collaborator

Summary

  • trust mitm proxy by default

Testing

  • Not run (explain why)
  • Unit tests
  • Integration tests
  • e2e / manual verification

Breaking Changes

  • None
  • Yes (describe impact and migration path)

Checklist

  • Linked Issue or clearly described motivation
  • Added/updated docs (if needed)
  • Added/updated tests (if needed)
  • Security impact considered
  • Backward compatibility considered

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 478c093b19

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

cert="$1"
if command -v update-ca-certificates >/dev/null 2>&1; then
mkdir -p /usr/local/share/ca-certificates
cp "$cert" /usr/local/share/ca-certificates/opensandbox-mitmproxy-ca.crt
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid hard-failing bootstrap when installing MITM CA

When OPENSANDBOX_EGRESS_MITMPROXY_TRANSPARENT is enabled, this path writes into system trust directories before starting execd; on non-root containers or read-only root filesystems, cp fails and set -e terminates the whole bootstrap, so the sandbox never starts. This is a compatibility regression because bootstrap.sh previously treated similar setup steps as best-effort (warning-only) for constrained images.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/execd feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants