Repository navigation
test(e2e): stabilize mobile layout readiness before assertions - #232
Merged
Merged
Conversation
Signed-off-by: alirezasafaei-dev <asdevelooper@gmail.com>
Signed-off-by: alirezasafaei-dev <asdevelooper@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the homepage DOM arrives before visible layout, the mobile E2E test measures zero-sized task/proof geometry and fails despite correct DOM order. Main CI run 38137683400 reproduced this at 360px and 390px after PR #233 merged.
This tests-only change waits for the heading, first task link and first proof article to be visible before measuring. The keyboard test also verifies the starting hero anchor is visible and focused. Existing geometry, DOM order, overflow, keyboard order and 44px target assertions remain unchanged; no retries or thresholds are relaxed.
Validation: updated targeted Chromium tests repeated four times against a local production standalone build, 8/8 passed with retries=0 at both widths. Prettier, licensing, repository secret checks, Gitleaks and production dependency audit passed. Independent review requested on updated visibility precondition. Hosted CI must pass on the exact updated head before merge.
Closes #231 for the homepage readiness race only; OCR/other baseline intermittent test failures remain separately observable. No deployment in this PR.