Repository navigation
fix(transformer): align sklearn feature-name contract - #98
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MissinglyImputer.get_feature_names_out()conform to the sklearn transformer contract by returning a one-dimensional objectnumpy.ndarrayin fit-time order.sklearn.clone, verifying cloned estimators retain constructor parameters but no fitted state.Coverage integrity
Official main baseline: 92.61% (3798/4101), with 303 uncovered lines. This PR changes no coverage threshold, omission, exclusion, pragma, or denominator configuration. The Python 3.12 CI artifact will determine the exact delta.
Verification
transformer.py, installed-module transformer doctests (26 passed), diff-check, and changed-lines <= 88 columns.Risk
get_feature_names_out()changes from a Python list to sklearn's standard ndarray output. Values and fit-time order remain unchanged. Other changes make impossible fitted-state corruption fail explicitly instead of leaking nullable/object internals.Refs #78
Refs #60
Refs #69