Conversation
204b1f0 to
05c1be4
Compare
| server.cmd_options = options | ||
|
|
||
| Rack::Handler.pick(['thin', 'webrick']).run server.new, :Host => options[:addr], :Port => options[:port] | ||
| Rackup::Handler.pick(['thin', 'webrick']).run server.new, :Host => options[:addr], :Port => options[:port] |
There was a problem hiding this comment.
does this mean this won't work on old ruby versions?
| :callees => callees(frame, info), | ||
| :location => file, | ||
| :source => BetterErrors::CodeFormatter::HTML.new(file, line).output | ||
| :source => file && line ? BetterErrors::CodeFormatter::HTML.new(file, line).output : nil |
There was a problem hiding this comment.
interesting in what scenario these are missing? maybe reproduce in unit test?
There was a problem hiding this comment.
I could for sure, they're missing in C methods.
|
I'm no longer working in Ruby ecosystem, so not sure i can properly review that. I left some comments, feel free to tackle them as you see fit. I also invited you to this repository as a collaborator. Once you accept the invite you will be able to merge/push by yourself. Also, let me know what's your RubyGems email, and I'll figure out a way to give access to you to push the gem there |
|
@alisnic fair enough, it's buonomo.ulysse@gmail.com but I'm currently trying to recover the account, so I can't push yet. I hope I'll figure it out soon. The comments are quite relevant, I'll address all of them :) |
- Update Ruby versions to 3.2, 3.3, and head - Use `actions/checkout@v4` instead of `actions/checkout@v2` - Cancel concurrent jobs
ad24f5c to
53a0454
Compare
| spec.add_dependency "haml", "~> 6.3.0" | ||
| spec.add_dependency "stackprof", ">= 0.2.13" | ||
| spec.add_dependency "better_errors", "~> 1.1.0" | ||
| spec.add_dependency "better_errors", "~> 2.10.1" |
There was a problem hiding this comment.
This actually fixes the cfunc bug. And closes #34
2 participants
Fixes #36
I've made a commit per fix, please tell me if you want separate PRs.