Fix Backward loop issue on pytorch 2.5#25
Open
ybh1998 wants to merge 1 commit into
Open
Conversation
|
@aliutkus could you please push this since this was the error I was finding as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried to back propagate on PyTorch 2.5.1, the program stuck at
loss.backward(). After some investigation, I found the following issue:When I add a breakpoint at
torchinterp1d/torchinterp1d/interp1d.py
Line 155 in 4e7533d
The
grad_fnofctx.saved_tensors[0]is<Interp1dBackward>, causing a loop backward call.When I add a breakpoint at
torchinterp1d/torchinterp1d/interp1d.py
Line 149 in 4e7533d
The
grad_fnofynewis<AddBackward0>, which means the grad_fn ofctx.saved_tensors[0]is touched between forward and backward. I tried to add.detach()after callinginterp1d, but the results were the same.I suspect that the PyTorch auto_grad engine modifies the
grad_fnofynewin-place after some version. Adding adetach()in the forward function resolves this problem.