Open
Conversation
alja
reviewed
Feb 4, 2026
alja
reviewed
Feb 4, 2026
alja
reviewed
Feb 4, 2026
alja
reviewed
Feb 4, 2026
alja
reviewed
Feb 4, 2026
alja
reviewed
Feb 4, 2026
REveCamera implement
added REveCamera class
implement isEveCameraPerspective
set REveCamera free as an independent class
implement camera on the client side. Also, the hardcoded test matrix is here
hardcoded matrix test
change the paths & env variables
myslef as the author
Remove commented lines with V1, V2
fCamera declaration does not need a comment.
Restore align.
include the REveCamera.hxx header in REveManager.cxx
GetCameraId() replaced with REveCamera* GetCamera() {return fCamera; }
SetCamBaseMtx override with string input
SetCameraByElementId function implement; Set default camera to kCameraPerspXOZ
save camera matrix implemented
alja
reviewed
Apr 8, 2026
| // console.log("resetRenderer 2D scene bbox ex ey", sbbox, ex, ey, ", camera_pos ", posC, ", look_at ", this.rot_center); | ||
| } | ||
|
|
||
| this.controls.setFromBBox(sbbox); |
Owner
There was a problem hiding this comment.
We need to introduce REveCamera::fIsInitialized bool member
If camera is not initialized the REveCameraControls position is set from bounding box
alja
reviewed
Apr 8, 2026
| this.controls.addEventListener('change', this.render.bind(this)); | ||
|
|
||
| // send to server when the client finishes camera setting | ||
| this.controls.addEventListener('end', () => { |
Owner
There was a problem hiding this comment.
@osschar @yuxiaolab
I'm not sure what would be best event listener.
In REveCameraControls the end event is displatched on MouseUp, TouchEnd, and on MouseWheel:
https://github.com/osschar/RenderCore/blob/main/src/contrib/REveCameraControls.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #