Bundle data files in pip package and fix hardcoded paths#69
Draft
atalyaalon wants to merge 1 commit intomainfrom
Draft
Bundle data files in pip package and fix hardcoded paths#69atalyaalon wants to merge 1 commit intomainfrom
atalyaalon wants to merge 1 commit intomainfrom
Conversation
atalyaalon
force-pushed
the
v0.49.0
branch
6 times, most recently
from
4795984 to
07a1434
Compare
- Move data/ into s2and/data/ so files ship with pip install - Add [tool.setuptools.package-data] for data/*.json and data/*.txt - Replace hand-rolled config loading in plotting_utils.py, scripts, and Dockerfile with canonical CONFIG from s2and.consts - Update Dockerfile to remove redundant COPY lines and target S3 downloads to s2and/data/ - Bump version to 0.49.0 across all packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data/intos2and/data/so files ship withpip install[tool.setuptools.package-data]fordata/*.jsonanddata/*.txtplotting_utils.pyand scripts with canonicalCONFIGfroms2and.constsDockerfile(not used in any CI/CD workflow)Test plan
test_plotting_utils,test_consts,test_datapass (14/14)CONFIGresolves data files correctly from installed package🤖 Generated with Claude Code