Fix numpy v2 incompatibility (#536)#565
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
Removes the numpy<2.0 version constraint that was causing binary
incompatibility errors ("numpy.dtype size changed") when numpy v2
is installed. The constraint was originally added while waiting for
spacy and nmslib to be rebuilt for numpy v2; both now support it.
Fixes allenai#536
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Not sure if im completely off track with this, but:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy<2.0upper bound constraint inpyproject.tomlthat was causing binary incompatibility errors (numpy.dtype size changed) with numpy v2numpy>=1.24.0to ensure a reasonably modern numpy versionFixes #536
Test plan
numpy.dtype size changederrors🤖 Generated with Claude Code