fix: use list comprehension instead of set in PerClassScorer.get_metric#583
Open
Chessing234 wants to merge 1 commit into
Open
fix: use list comprehension instead of set in PerClassScorer.get_metric#583Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
Set comprehensions passed to sum() silently deduplicate equal values. If two entity types have the same true-positive (or FP/FN) count, the set collapses them to one element before summation, producing an incorrectly low overall precision/recall/F1. Co-Authored-By: Chessing234 <takshkothari09@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
PerClassScorer.get_metriccomputes overall precision/recall/F1 by summing the true-positive, false-positive, and false-negative counts across all entity types (excluding"untyped"). The threesum()calls use set comprehensions ({v for k, v in ...}), which silently deduplicate equal values before summation.Root cause
{3, 3}evaluates to{3}, so if two entity types have the same count, one is dropped. For example, if labelsAandBeach have 3 true positives,sum({3, 3})returns3instead of6. The resulting overall metrics are incorrectly low whenever any two entity types share a count value.Fix
Change the three set comprehensions to list comprehensions. Lists preserve all values, so
sum([3, 3])correctly returns6.The fix is identical for
sum_false_positivesandsum_false_negatives.