Fix resize QuesoScrollable#274
Open
AurelienVigne wants to merge 3 commits intodevfrom
Open
Conversation
belleymambo
requested changes
Mar 26, 2026
| <script setup lang="ts"> | ||
| import { computed, nextTick, onMounted, ref, useSlots, watchEffect } from "vue"; | ||
| import { computed, nextTick, onMounted, ref, useSlots, watch, watchEffect } from "vue"; | ||
| import { useScroll, useResizeObserver } from "@vueuse/core"; |
Collaborator
There was a problem hiding this comment.
useResizeObserver est déjà un ResizeObserver. Est-ce qu'il y aurait moyen de merge tout ensemble ou de vérifier si c'est useResizeObserver qui est mal intégré?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ResizeObserverandMutationObserverso overflow and scroll state update when slot content grows or shrinks (fixed-height container no longer misses those changes).types.tstoQuesoScrollable.types.tsand align the barrel export with the component import.Breaking changes
@components/QuesoScrollable. Deep imports of./typesfrom the component folder would need to point at./QuesoScrollable.typesinstead.Close #273
Made with Cursor