Refactor for loops to use purrr in mapvizier_summary.R#328
Merged
Conversation
Replace imperative for loops with purrr::pmap_int() for calculating cohort status NPRs in summary.mapvizieR_growth and summary.mapvizieR_cdf. - Use purrr::pmap_int() to vectorize cohort_mean_rit_to_npr calls - Add purrr (>= 1.0.0) as package dependency - Cleaner, more functional approach following tidyverse idioms Fixes #314
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
purrr::pmap_int()for calculating cohort status NPRssummary.mapvizieR_growthandsummary.mapvizieR_cdffunctionspurrr (>= 1.0.0)as package dependencyChanges
Before (imperative):
After (functional):
Test plan
Fixes #314