fix broker output forwarding under backpressure#205
Merged
Conversation
almogdepaz
marked this pull request as ready for review
July 22, 2026 12:31
almogdepaz
marked this pull request as draft
July 22, 2026 14:19
almogdepaz
force-pushed
the
fix/take-control-output-lag
branch
from
July 22, 2026 16:46
09c5625 to
bb3c9e2
Compare
almogdepaz
marked this pull request as ready for review
July 22, 2026 16:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stacked on
fix/mobile-keyboard-grid-polish)problem
During take-control on high-output TUIs, broker output forwarding can lag its 256-chunk broadcast receiver. The server then gets
SubscriptionDropped/replay_truncated, reconnects the browser, and exposes redraw bytes as a visible character stream. The first implementation also allowed output to occupy the shared writer queue and starve control RPCs.Live repros dropped 203–2,445 chunks per cycle.
change
subscription_droppedbehind accepted output as a replay-ordering barrierseqas the final PTY-chunk watermark covered by a frameregressions
subscription_droppedsubscription forwarder lagged broadcastwarningsverification
rustfmt --checkgit diff --checkdeployment status
The initial broker implementation was deployed as PID
28214, and #196’s server candidate is live as PID68020. The latest review-fix commit09c5625is not deployed; it requires another approved broker restart.Live #196 assets currently remain:
b2f548b08b293a80be1932659da375c6f05b96b946d09ac8b95103cafd5b252120a5074d3ef7a4e8aa5555ffc7c2ac936227cd094bd5949a7be08a2711a68f57release gates
This remains draft pending final repeat differential review and real Android/Gboard verification for #196.