refactor(hooks): remove dead rewrite_forge_p function#4
Open
shafqatevo wants to merge 2 commits into
Open
Conversation
The function was never called — decide_bash duplicates its logic inline. Also eliminates a subtle hazard: if ever called, it would generate a second UUID distinct from the one validated at the decide_bash call site. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ode removal Reflects the new hash of hooks/forge-delegation-enforcer.sh after rewrite_forge_p was removed in the previous commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
shafqatevo
force-pushed
the
main
branch
7 times, most recently
from
0cc6570 to
5a6e025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rewrite_forge_p()(26 lines + comment block) fromhooks/forge-delegation-enforcer.sh— the function was never called;decide_bashduplicates its logic inlinegen_uuidinternally, producing a second UUID different from the one already validated at thedecide_bashcall siteplugin.jsonmanifest SHA256 to match the modified fileTest Plan
tests/test_forge_enforcer_hook.bash— 20/20 passtests/test_plugin_integrity.bash— 13/13 pass (SHA integrity check now passes)🤖 Generated with Claude Code