Skip to content

Adding calculated_total to payday#7

Open
katiaAlexandrov wants to merge 1 commit into
masterfrom
payday-support-calculated-total
Open

Adding calculated_total to payday#7
katiaAlexandrov wants to merge 1 commit into
masterfrom
payday-support-calculated-total

Conversation

@katiaAlexandrov

Copy link
Copy Markdown
Collaborator

No description provided.

@katiaAlexandrov

Copy link
Copy Markdown
Collaborator Author

@alonhartal please review and push, need this change in order to change our backend

Comment thread lib/payday/invoiceable.rb

# Calculates the total for this invoice.
def total
return calculated_total if defined?(calculated_total) && calculated_total

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll have some issue with merging the previous branch right?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alonhartal why? in case of tax?

@alonhartal alonhartal changed the base branch from master to fix_big_decimal_issue December 5, 2018 14:22
@alonhartal alonhartal changed the base branch from fix_big_decimal_issue to master December 5, 2018 14:22
@alonhartal alonhartal closed this Dec 5, 2018
@alonhartal alonhartal reopened this Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants