fix(prover-perf): use a DA-backed checkpoint fixture#1868
Conversation
|
Replay checkpoint perf inputs through the real DA accumulation path and replace a deprecated digest output type that was triggering a succinct rustc ICE during guest builds.
|
Rebased this onto current main and resolved the checkpoint fixture conflict. This branch still only changes Cargo.lock, bin/prover-perf/Cargo.toml, and bin/prover-perf/src/programs/checkpoint.rs. I reran cargo fmt --all --check, cargo test -p strata-proofimpl-checkpoint program::tests::test_statements_success -- --nocapture, and cargo check -p strata-provers-perf --bin strata-provers-perf in WSL after the rebase. All three passed. |
0df5273 to
3c3139a
Compare
Description
Restores a realistic checkpoint perf fixture by deriving the DA witness from the same replay path used by checkpoint generation.
The old fixture had fallen back to an empty-chain path because the guest now requires a valid DA witness. That made the reported checkpoint cycle counts understate the real checkpoint workload.
This change builds a transaction-bearing chain, replays the epoch through
DaAccumulatingState, and takesda_state_diff_bytesfromexecute_block_batch_presealinstead of hand-building a slot-only DA payload. It also drops the DA helper dependencies that are no longer used by this path.Type of Change
Notes to Reviewers
This branch no longer carries the separate digest alias change. That toolchain-compatibility fix now lives only in
#1872.The release before/after numbers for this fixture use this patch together with
#1872, becauserustc +succinctstill ICEs on the deprecated alias path without that separate unblock.AI was used to assist in this PR.
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues