Skip to content

fix(prover-perf): use a DA-backed checkpoint fixture#1868

Open
peter941221 wants to merge 2 commits into
alpenlabs:mainfrom
peter941221:fix/checkpoint-perf-realistic
Open

fix(prover-perf): use a DA-backed checkpoint fixture#1868
peter941221 wants to merge 2 commits into
alpenlabs:mainfrom
peter941221:fix/checkpoint-perf-realistic

Conversation

@peter941221
Copy link
Copy Markdown

@peter941221 peter941221 commented May 27, 2026

Description

Restores a realistic checkpoint perf fixture by deriving the DA witness from the same replay path used by checkpoint generation.

The old fixture had fallen back to an empty-chain path because the guest now requires a valid DA witness. That made the reported checkpoint cycle counts understate the real checkpoint workload.

This change builds a transaction-bearing chain, replays the epoch through DaAccumulatingState, and takes da_state_diff_bytes from execute_block_batch_preseal instead of hand-building a slot-only DA payload. It also drops the DA helper dependencies that are no longer used by this path.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

This branch no longer carries the separate digest alias change. That toolchain-compatibility fix now lives only in #1872.

The release before/after numbers for this fixture use this patch together with #1872, because rustc +succinct still ICEs on the deprecated alias path without that separate unblock.

AI was used to assist in this PR.

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

@peter941221 peter941221 marked this pull request as ready for review May 29, 2026 10:16
@peter941221
Copy link
Copy Markdown
Author

  1. I pushed 0df5273 to remove the digest alias change from this branch.

  2. That toolchain-compatibility fix now lives only in alpen#1872. The live file list for this PR is back to the checkpoint fixture change plus its lockfile update.

  3. I also tightened the PR body so the benchmark boundary is explicit: the release before/after numbers use this fixture change together with fix(acct-types): use digest Output alias #1872 as the separate guest-toolchain unblock.

@peter941221 peter941221 changed the title fix(prover-perf): restore realistic checkpoint perf fix(prover-perf): use a DA-backed checkpoint fixture May 31, 2026
Replay checkpoint perf inputs through the real DA accumulation path and replace a deprecated digest output type that was triggering a succinct rustc ICE during guest builds.
@peter941221
Copy link
Copy Markdown
Author

peter941221 commented Jun 1, 2026

Rebased this onto current main and resolved the checkpoint fixture conflict.

This branch still only changes Cargo.lock, bin/prover-perf/Cargo.toml, and bin/prover-perf/src/programs/checkpoint.rs.

I reran cargo fmt --all --check, cargo test -p strata-proofimpl-checkpoint program::tests::test_statements_success -- --nocapture, and cargo check -p strata-provers-perf --bin strata-provers-perf in WSL after the rebase. All three passed.

@peter941221 peter941221 force-pushed the fix/checkpoint-perf-realistic branch from 0df5273 to 3c3139a Compare June 1, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant