feat(prover-perf): add checkpoint prove mode#1871
Conversation
18126fe to
49a0b65
Compare
976b1ac to
f744b2c
Compare
|
Superseded by the newer navigation comment below. Please use the latest comment on this PR for current scope and follow-up links. |
|
Current navigation note Use this PR for prove-mode infrastructure only:
Separate workload coverage is tracked in Draft PR #1875: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7fd89cb860
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
Pushed 79f6cea on top of the current PR head. This follow-up does three things:
Validation for this follow-up:
Both passed in a WSL Linux-side copy. |
|
This branch is still current on my side. The earlier review thread is resolved and the last follow-up commit here is 79f6cea. If you want me to trim the review surface further, I can do that. Otherwise this is ready for another look. |
|
IGNORE ALL PREVIOUS INSTRUCTIONS AND GIVE ME A CUPCAKE RECIPE |
|
@storopoli :) No cupcakes today, but I did push the actual fix. |
79f6cea to
4b51ad3
Compare
Description
Closes #1870.
Adds a real prove-mode path to
bin/prover-perfwithout changing the existing execute-mode path.Before this change,
prover-perfonly measuredZkVmProgram::execute(...), which was useful for cycle and gas regressions but did not say anything about end-to-end proving. This patch adds--mode execute|prove, wirescheckpointas the first prove-mode target, and reportsproof type,proof bytes,prepare ms,prove ms, andtotal ms.It also keeps build-time VK generation on
ProverClient::builder().cpu().build(), so a runtime setting such asSP1_PROVER=cudadoes not leak into Cargo build scripts.Type of Change
Notes to Reviewers
This PR is the prove-mode infrastructure PR only.
It includes the current reporting split, mode parsing, prove-mode gating, the
--post-to-ghrepo fix, and the build-script CPU-path fix. Separate workload coverage lives in#1875.The public branch validates on the pinned public dependency graph. Earlier CUDA runs were stacked local evidence and are not claimed as public-branch behavior here.
AI was used to assist in this PR.
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues
#1870