STR-3701: Reconcile stale checkpoint artifacts on startup#1926
Merged
Conversation
Contributor
|
Commit: 3c67176 SP1 Execution Results
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #1926 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.01%
==========================================
Files 637 638 +1
Lines 76805 76963 +158
==========================================
+ Hits 64840 64971 +131
- Misses 11965 11992 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
voidash
requested review from
bewakes,
delbonis,
krsnapaudel,
prajwolrg and
storopoli
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 461e1cb845
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
storopoli
requested changes
Jun 2, 2026
delbonis
approved these changes
Jun 2, 2026
Startup reconciliation deletes unaccepted checkpoint payloads, proofs, and prover tasks, but nothing re-drove their rebuild on a restart where no new terminal epoch arrived: the epoch-summary watch channel is re-created as `None` and never replays persisted summaries, so the checkpoint worker and prover runner both stayed idle. Drive a one-shot catch-up in the checkpoint worker's `on_launch` to rebuild payloads for already-summarized epochs, and seed the prover runner's `latest_epoch` from `get_last_summarized_epoch` so cleared proofs are regenerated without waiting for a fresh watch notification.
main renamed `AsmStateManager::fetch_most_recent_state` to explicit `_blocking`/`_async` variants; use the blocking accessor in checkpoint reconciliation so the branch builds against current main.
voidash
force-pushed
the
feat/stale-checkpoint-bye-bye
branch
from
60f15b9 to
97d94bf
Compare
Contributor
Author
|
All review threads are resolved and CI is green on current head |
storopoli
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira: STR-3701