Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84af5c685c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| use strata_acct_types::{ | ||
| AccountId, AccountSerial, BRIDGE_GATEWAY_ACCT_ID, BRIDGE_GATEWAY_ACCT_SERIAL, | ||
| }; |
There was a problem hiding this comment.
Preserve old OL STF constant exports
If any existing consumer imports strata_ol_stf::BRIDGE_GATEWAY_ACCT_ID or BRIDGE_GATEWAY_ACCT_SERIAL, this private import removes those public symbols because pub use constants::* in lib.rs can only re-export public items from this module. Since this is marked as a refactor/non-breaking move, keep compatibility by re-exporting the new strata_acct_types constants from strata-ol-stf as well.
Useful? React with 👍 / 👎.
|
Commit: b567eb6 SP1 Execution Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1936 +/- ##
==========================================
- Coverage 84.31% 84.29% -0.02%
==========================================
Files 634 634
Lines 75817 75817
==========================================
- Hits 63924 63912 -12
- Misses 11893 11905 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Description
Moves shared bridge gateway account constants from
strata-ol-stftostrata-acct-types:BRIDGE_GATEWAY_ACCT_IDBRIDGE_GATEWAY_ACCT_SERIALUpdates downstream users to import these constants from
strata_acct_typesand removes duplicated bridge gateway values.Why Only These Constants
SEQUENCER_ACCT_IDandSEQUENCER_ACCT_SERIALwere intentionally left inol/stf.They are currently aliases of the bridge gateway account, but semantically they represent STF execution behavior for senderless GAM transactions. They are not yet stable shared account identities.
Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues
STR-3358