Skip to content

STR 3358 Split constant OL account values to strata_acct_types crate#1936

Merged
storopoli merged 1 commit into
mainfrom
STR-3358
Jun 8, 2026
Merged

STR 3358 Split constant OL account values to strata_acct_types crate#1936
storopoli merged 1 commit into
mainfrom
STR-3358

Conversation

@krsnapaudel
Copy link
Copy Markdown
Contributor

@krsnapaudel krsnapaudel commented Jun 3, 2026

Description

Moves shared bridge gateway account constants from strata-ol-stf to strata-acct-types:

  • BRIDGE_GATEWAY_ACCT_ID
  • BRIDGE_GATEWAY_ACCT_SERIAL

Updates downstream users to import these constants from strata_acct_types and removes duplicated bridge gateway values.

Why Only These Constants

SEQUENCER_ACCT_ID and SEQUENCER_ACCT_SERIAL were intentionally left in ol/stf.

They are currently aliases of the bridge gateway account, but semantically they represent STF execution behavior for senderless GAM transactions. They are not yet stable shared account identities.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

STR-3358

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 84af5c685c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +1 to +3
use strata_acct_types::{
AccountId, AccountSerial, BRIDGE_GATEWAY_ACCT_ID, BRIDGE_GATEWAY_ACCT_SERIAL,
};
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve old OL STF constant exports

If any existing consumer imports strata_ol_stf::BRIDGE_GATEWAY_ACCT_ID or BRIDGE_GATEWAY_ACCT_SERIAL, this private import removes those public symbols because pub use constants::* in lib.rs can only re-export public items from this module. Since this is marked as a refactor/non-breaking move, keep compatibility by re-exporting the new strata_acct_types constants from strata-ol-stf as well.

Useful? React with 👍 / 👎.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Commit: b567eb6

SP1 Execution Results

program cycles gas
EVM EE Chunk 824,732 969,394
EVM EE Account 404,056 498,593
Checkpoint 2,602,415 3,010,370

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.29%. Comparing base (dde9c3c) to head (84af5c6).

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   84.31%   84.29%   -0.02%     
==========================================
  Files         634      634              
  Lines       75817    75817              
==========================================
- Hits        63924    63912      -12     
- Misses      11893    11905      +12     
Flag Coverage Δ
functional 65.87% <100.00%> (-0.04%) ⬇️
unit 69.57% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
bin/strata-test-cli/src/mock_ee/withdrawal.rs 100.00% <ø> (ø)
...tes/alpen-ee/sequencer/src/block_builder/config.rs 53.84% <100.00%> (ø)
crates/evm-ee/src/execution.rs 83.77% <100.00%> (ø)
crates/ol/block-assembly/src/test_utils.rs 98.80% <ø> (ø)
crates/ol/stf/src/account_processing.rs 99.00% <ø> (ø)
crates/ol/stf/src/manifest_processing.rs 94.44% <ø> (ø)
crates/ol/stf/src/test_utils.rs 85.81% <ø> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@krsnapaudel krsnapaudel self-assigned this Jun 4, 2026
Copy link
Copy Markdown
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 84af5c6

@storopoli storopoli merged commit 613cde5 into main Jun 8, 2026
32 of 33 checks passed
@storopoli storopoli deleted the STR-3358 branch June 8, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants