fix(ci): stabilize SP1 E2E proof assertions#1938
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a0110c3f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Commit: 16bcf80 SP1 Execution Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1938 +/- ##
==========================================
+ Coverage 84.30% 84.44% +0.14%
==========================================
Files 633 637 +4
Lines 75681 76670 +989
==========================================
+ Hits 63803 64747 +944
- Misses 11878 11923 +45
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@voidash It was an agreed condition to ensure an epoch containing SAU is verified.
Could you update it accordingly!
Also if the main issue was signet image download being throttled why retries won't fix this? Regarding two epochs being proven and confirmed it used to happen within 15-20 mins so why nowadays it is not happening in 40mins?
2a0110c to
3a7023a
Compare
3a7023a to
3a9310d
Compare
purusang
left a comment
There was a problem hiding this comment.
The issue is in SP1 side so may be we should move from centralized reserved network to decentralized prover servies.
Summary
Verification
bash -n .github/sp1-e2e/run-test.sh.github/workflows/ci-sp1-e2e.yml