Skip to content

fix(ci): stabilize SP1 E2E proof assertions#1938

Open
voidash wants to merge 5 commits into
mainfrom
fix/sp1-e2e-signet-retry
Open

fix(ci): stabilize SP1 E2E proof assertions#1938
voidash wants to merge 5 commits into
mainfrom
fix/sp1-e2e-signet-retry

Conversation

@voidash
Copy link
Copy Markdown
Contributor

@voidash voidash commented Jun 4, 2026

Summary

  • retry signet startup to tolerate public ECR throttling
  • keep real SP1 coverage: one confirmed checkpoint proof plus one accepted and checkpoint-confirmed SAU/SNARK update
  • keep CI on the reserved SP1 proving path; auction proving should be handled separately once funding/account ownership is coordinated
  • keep proof wait time aligned with SP1 network behavior while preserving the SAU epoch confirmation assertion

Verification

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2a0110c3f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/sp1-e2e/run-test.sh Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Commit: 16bcf80

SP1 Execution Results

program cycles gas
EVM EE Chunk 824,732 969,395
EVM EE Account 404,056 498,593
Checkpoint 2,601,525 3,007,269

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.44%. Comparing base (1c9a7a5) to head (2a8307e).
⚠️ Report is 6 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
+ Coverage   84.30%   84.44%   +0.14%     
==========================================
  Files         633      637       +4     
  Lines       75681    76670     +989     
==========================================
+ Hits        63803    64747     +944     
- Misses      11878    11923      +45     
Flag Coverage Δ
functional 66.41% <ø> (+0.57%) ⬆️
unit 69.76% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 97 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@purusang purusang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@voidash It was an agreed condition to ensure an epoch containing SAU is verified.
Could you update it accordingly!

Also if the main issue was signet image download being throttled why retries won't fix this? Regarding two epochs being proven and confirmed it used to happen within 15-20 mins so why nowadays it is not happening in 40mins?

@voidash voidash force-pushed the fix/sp1-e2e-signet-retry branch from 2a0110c to 3a7023a Compare June 4, 2026 16:57
Copy link
Copy Markdown
Contributor

@purusang purusang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is in SP1 side so may be we should move from centralized reserved network to decentralized prover servies.

Comment thread .github/workflows/ci-sp1-e2e.yml Outdated
Comment thread .github/sp1-e2e/.env.ci Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants