Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c9132534c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1941 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.01%
==========================================
Files 637 637
Lines 76805 76817 +12
==========================================
+ Hits 64840 64845 +5
- Misses 11965 11972 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Commit: 1e4fc6d SP1 Execution Results
|
delbonis
left a comment
There was a problem hiding this comment.
Pretty minor comment, approving otherwise.
Description
Adds
strata_getSnarkAcctInboxMsgRange(account_id, start, end)toOLClientRpc.The range is half-open
[start, end). The RPC returnsVec<RpcIndexedEntry<RpcMessageEntry>>, pairing each Snark account inbox messagewith its absolute inbox index.
The implementation reuses the existing
OLRpcProvider::get_account_inbox_messagesstorage/MMR path.Changes:
crates/ol/rpc/types/src/account_summary.rs: add genericRpcIndexedEntry<T>(Serialize/Deserialize/JsonSchema).crates/ol/rpc/types/src/lib.rs: re-exportRpcIndexedEntry.crates/ol/rpc/api/src/lib.rs: addgetSnarkAcctInboxMsgRangetoOLClientRpcwith[start, end)semantics.bin/strata/src/rpc/node.rs: validatestart <= end, call the provider, and enumerate results fromstart. Includes a debug_assert! against storage range regressions and delegates unknown-account behavior to the existing storage/MMR lookup.bin/strata/src/rpc/node_tests.rs: add tests for valid range, empty range, reversed range, and provider error mapping.This PR was created with help from Codex and Claude Code.
Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues
STR-3717