feat(sp1-e2e): pin checkout to selected image commit#1945
Conversation
…scripts - previously we used to select arbitrary image but latest version of workflow was used to orchestrate the run
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b973eab97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| BUILD_SHA=$(gh run list -R "${REPO}" \ | ||
| --workflow ci-build.yml \ | ||
| --status success \ | ||
| --limit 100 \ | ||
| --json headSha \ | ||
| --jq ".[] | select(.headSha | startswith(\"${SHORT_TAG}\")) | .headSha" | head -n1) |
There was a problem hiding this comment.
When ci-build.yml is manually dispatched with its supported ref input, the images are tagged from git rev-parse HEAD after checking out inputs.ref, not from the workflow run's headSha (.github/workflows/ci-build.yml lines 129 and 217-220). This new resolver searches only gh run list --json headSha, so a valid manually built image tag from that ref cannot be found and the SP1 E2E manual run exits with should_run=false instead of testing the requested image.
Useful? React with 👍 / 👎.
|
Commit: b595590 SP1 Execution Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1945 +/- ##
==========================================
- Coverage 84.42% 84.38% -0.04%
==========================================
Files 637 637
Lines 76805 76805
==========================================
- Hits 64840 64812 -28
- Misses 11965 11993 +28
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
1 participant
Description
Pins the SP1 E2E workflow checkout to the commit that produced the selected Docker images by default. This keeps workflow scripts, Docker compose files, and datatool assumptions aligned with the image tag under test.
Manual runs can still pass
checkout_refto test workflow changes from a branch against an existing image tag.Type of Change
Notes to Reviewers
The default path preserves STR-3529's anti-drift behavior: when
checkout_refis omitted,actions/checkoutuses the resolved image commit SHA. The override is only for manual workflow debugging.Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Validation:
git diff --checkactionlint .github/workflows/ci-sp1-e2e.ymlAI assistance notice: This PR was prepared with AI assistance.
Related Issues
STR-3529