refactor(ci): pin genparams checkout to image commit#1946
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4de75962a5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Commit: eefdc6d SP1 Execution Results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1946 +/- ##
==========================================
- Coverage 84.42% 84.42% -0.01%
==========================================
Files 637 637
Lines 76805 76805
==========================================
- Hits 64840 64839 -1
- Misses 11965 11966 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Description
Pins the
ci-genparams.ymlcheckout to the commit that produced the selectedstrata-datatoolimage by default. This keeps the params generation script, templates, chainspec, and datatool image aligned for a given image tag.Manual runs can still pass
checkout_refto test workflow changes from a branch against an existing datatool image tag.Type of Change
Notes to Reviewers
The default path avoids commit drift: when
checkout_refis omitted,actions/checkoutuses the full SHA behind the selected datatool image tag. The override exists only for manual workflow debugging.Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Validation:
git diff --checkactionlint .github/workflows/ci-genparams.ymlAI assistance notice: This PR was prepared with AI assistance.
Related Issues
N/A