Skip to content

refactor(ci): pin genparams checkout to image commit#1946

Merged
purusang merged 1 commit into
mainfrom
refactor/pin-genparams-checkout-ref
Jun 8, 2026
Merged

refactor(ci): pin genparams checkout to image commit#1946
purusang merged 1 commit into
mainfrom
refactor/pin-genparams-checkout-ref

Conversation

@purusang

@purusang purusang commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Description

Pins the ci-genparams.yml checkout to the commit that produced the selected strata-datatool image by default. This keeps the params generation script, templates, chainspec, and datatool image aligned for a given image tag.

Manual runs can still pass checkout_ref to test workflow changes from a branch against an existing datatool image tag.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

The default path avoids commit drift: when checkout_ref is omitted, actions/checkout uses the full SHA behind the selected datatool image tag. The override exists only for manual workflow debugging.

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Validation:

  • git diff --check
  • actionlint .github/workflows/ci-genparams.yml

AI assistance notice: This PR was prepared with AI assistance.

Related Issues

N/A

@purusang purusang self-assigned this Jun 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4de75962a5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/ci-genparams.yml
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Commit: eefdc6d

SP1 Execution Results

program cycles gas
EVM EE Chunk 824,732 969,394
EVM EE Account 404,056 498,593
Checkpoint 2,601,550 3,007,194

@codecov

codecov Bot commented Jun 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.42%. Comparing base (b5d34b8) to head (4de7596).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #1946      +/-   ##
==========================================
- Coverage   84.42%   84.42%   -0.01%     
==========================================
  Files         637      637              
  Lines       76805    76805              
==========================================
- Hits        64840    64839       -1     
- Misses      11965    11966       +1     
Flag Coverage Δ
functional 66.50% <ø> (-0.01%) ⬇️
unit 69.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4de7596

I don't understand the codex P2 finding, please take a look.

@purusang purusang added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 033a139 Jun 8, 2026
33 checks passed
@purusang purusang deleted the refactor/pin-genparams-checkout-ref branch June 8, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants