feat(alpen-client): add tag to alpen logs to distinguish from reth logs#1948
feat(alpen-client): add tag to alpen logs to distinguish from reth logs#1948sapinb wants to merge 2 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: de48846e8b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Commit: 10e4a4b SP1 Execution Results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1948 +/- ##
==========================================
- Coverage 84.46% 84.42% -0.05%
==========================================
Files 637 637
Lines 76670 76695 +25
==========================================
- Hits 64757 64746 -11
- Misses 11913 11949 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Add a tag `component = alpen` on all non-reth logs to allow easier filtering for monitoring.
sapinb
force-pushed
the
feat/reth-alpen-log-split
branch
from
de48846 to
908c683
Compare
Convert all info_span that add component = "alpen" tags on alpen service logs to error_span. This ensures the tag is always added regardless of log level.
sapinb
force-pushed
the
feat/reth-alpen-log-split
branch
from
908c683 to
ac62b4e
Compare
| let health_check_addr = format!("{}:{}", ext.health_check_host, ext.health_check_port); | ||
| let _health_check_handle = | ||
| start_health_check_server(health_check_addr.clone(), health_check_state.clone()) | ||
| .instrument(error_span!("start_health_check_server", component = "alpen")) |
There was a problem hiding this comment.
Won't error_span log error when this span terminates even though it is not an error?
I do not think there is any. cc: @madan-oss |
|
@sapinb rebase |
5 participants
Description
Add a tag
component = alpenon all non-reth logs to allow logs from reth and non-reth (ie. alpen services) to be filtered and displayed separately.Type of Change
Notes to Reviewers
This looks pretty messy right now, but should get better over time as we clean up the binary code and move more parts to use service framework. Please do suggest if there is a better way to do this right now.
@purusang @madan-oss will
component = alpenconflict with anything currently in our log monitoring ?Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues