Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Both binaries in
util/hardcoded the input circuit path(
/Users/user/g16.ckt), so choosing a different circuit file meant editing thesource and recompiling. This changes
benchanddupecheckto take the circuitfile path as a required positional CLI argument instead.
clap-derivedCliwith one positionalinput: PathBufto each binary.clapwas already a workspace dependency, so it is just added to the twocrates'
[dependencies]; no new dependency is introduced.START/NUMand the rest of each tool are untouched.Usage:
Type of Change
Notes to Reviewers
Per the issue, the remaining hardcoded paths were in
util/benchandutil/dupecheck; this covers both.Two disclosures:
and to help draft this description. I reviewed the change myself.
confirm formatting, clippy, and tests. The two checklist items about warnings
and tests are left unchecked until CI verifies them.
I used a positional argument rather than an
--inputflag since there is asingle required input; happy to switch to a flag if you'd prefer.
Checklist
Related Issues
Closes #14