Skip to content

Fix/fix pyproject urls - #68

Merged
alphacrack merged 1 commit into
alphacrack:mainfrom
APK-hanal:fix/fix-pyproject-urls
Aug 5, 2026
Merged

Fix/fix pyproject urls#68
alphacrack merged 1 commit into
alphacrack:mainfrom
APK-hanal:fix/fix-pyproject-urls

Conversation

@APK-hanal

@APK-hanal APK-hanal commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Fixes #46

What & why

This change fixed the issue with project URL's in the pyproject.toml file.
Fixes #

Behavior change

  • User-facing: None
  • CLI / API surface: None
  • Config / env vars: None
  • Cost / performance: None

How to review

About 5 lines changed in the 'pyproject.toml' file.

Test evidence

Manual verification -> Confirmed the URLs now match the repository's actual location.

Checklist

  • [ x] Targets development (not main).
  • [x ] Commits are DCO-signed (git commit -s).
  • [x ] ruff check src/ tests/ and ruff format --check src/ tests/ clean.
  • [ x] mypy src/iac_scanner clean (CI is --strict).
  • Tests added / updated (pytest tests/ -m "not e2e").
  • CHANGELOG.md [Unreleased] updated for user-visible behavior.
  • If this touches prompts in orchestration/tasks.py: PROMPT_VERSION bumped.
  • If this changes cache format: SCHEMA_VERSION in cache.py bumped.
  • [ x] No new runtime deps (or, if added, justified below).

Roll-out notes

None

@APK-hanal
APK-hanal requested a review from alphacrack as a code owner July 24, 2026 15:59
@github-actions github-actions Bot added dependencies Runtime / dev dependency upgrade (Dependabot uses this name) area:cache Content-addressed response cache area:cli iac-scan CLI (click) / entry points area:llm LLM providers (OpenAI, Anthropic, GitHub Models, Ollama) area:mcp iac-scan-mcp server for Claude Desktop / Cursor area:scanners Terraform / CDK scanners, filters, skip-list area:release release.py, publish-pypi.yml, tag flow, PyPI area:orchestration Analysis + fix pipeline, LangChain tasks, hybrid runner area:docs README, CONTRIBUTING, docs/ site, CHANGELOG area:sarif SARIF 2.1.0 output area:ci .github/workflows, pre-commit, release automation area:cost tiktoken preflight + budget enforcement area:rules Rule-engine plugins (Checkov, cdk-nag, discovery) labels Jul 24, 2026
@alphacrack

Copy link
Copy Markdown
Owner

Thanks for jumping on this, @APK-hanal — and welcome! 🎉 Your actual change is exactly right: commit ed400aa flips all five [project.urls] entries from bishwasjha to alphacrack (including the alphacrack.github.io docs URL), one file, five lines. That's precisely what #46 asked for.

There's one thing blocking the merge, and it's not your edit — it's the base your branch was cut from.

What's happening

Your branch started from 0c2cefd (a v0.4.0-era commit), which is ~27 commits behind current main. Because of that, GitHub shows this PR as 64 files / +7,137 / −426 and marks it CONFLICTING — it's trying to also "undo" all the hardening work that landed on main since then. Merging it as-is would roll main back to v0.4.0, so I can't take it in this form even though your 5-line fix is perfect.

How to fix it (2 minutes)

# from your fork clone, on your branch:
git remote add upstream https://github.com/alphacrack/iac-scanner.git   # skip if already added
git fetch upstream
git rebase upstream/main
# (your one commit replays cleanly on top of current main — the URL lines are unchanged there)
git push --force-with-lease

After that, this PR will show just pyproject.toml / +5 −5, CI will run clean, and I'll merge it right away.

One tiny thing to add while you're at it: put Fixes #46 in the PR description so the issue auto-closes on merge.

Really nice first contribution — this is a real bug that affects the PyPI project page, so thank you. Ping me here if the rebase gives you any trouble. 🙌

Signed-off-by: APK-hanal <apilkhanal10@gmail.com>
@APK-hanal
APK-hanal force-pushed the fix/fix-pyproject-urls branch from ed400aa to a6f085d Compare July 28, 2026 10:24
@APK-hanal

Copy link
Copy Markdown
Contributor Author

@alphacrack Rebased onto the actual current main, Should just be Fix/fixpyproject urls +5-5 now, I added the Fix #46 as well to the description, Let me know if anything else is needed !!

@alphacrack alphacrack left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased onto current main, diff is now exactly the 5 URL lines, CI green (20/20). Fixes #46. Thank you! 🎉

@alphacrack
alphacrack merged commit e1cdae7 into alphacrack:main Aug 5, 2026
20 checks passed
alphacrack added a commit that referenced this pull request Aug 5, 2026
## Why

Three first-time-contributor PRs open right now (#68, #69, #70) were all
cut from a stale base and are unmergeable — because `CONTRIBUTING.md`,
`CLAUDE.md`, and the PR template told them to branch from and target
**`development`**, a branch frozen ~27 commits behind `main` since the
v0.4.0 era. Everything actually ships from `main` (now protected). This
PR fixes the misdirection.

## Changes

- **CONTRIBUTING.md** — branch from / target `main`; add a one-time
fork-sync snippet (`git remote add upstream … && git fetch upstream`)
and a "if your PR shows dozens of files, rebase" troubleshooting note.
- **PULL_REQUEST_TEMPLATE.md** — target `main`; the checklist now asks
authors to confirm their branch is rebased on current `main` (diff shows
only their files).
- **CLAUDE.md** — state that `main` is the single trunk.

## Follow-up (separate, needs maintainer)

Delete the `development` branch now that nothing points at it. Its 8
commits are old pre-squash v0.4.0 work already represented in `main`.

## Checklist

- [x] Docs-only, no code/runtime change
- [x] DCO signed
- [x] Makes the review comments left on #68/#69/#70 accurate

Fixes the root cause behind #68, #69, #70 base confusion.

Signed-off-by: alphacrack <18480504+alphacrack@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:cache Content-addressed response cache area:ci .github/workflows, pre-commit, release automation area:cli iac-scan CLI (click) / entry points area:cost tiktoken preflight + budget enforcement area:docs README, CONTRIBUTING, docs/ site, CHANGELOG area:llm LLM providers (OpenAI, Anthropic, GitHub Models, Ollama) area:mcp iac-scan-mcp server for Claude Desktop / Cursor area:orchestration Analysis + fix pipeline, LangChain tasks, hybrid runner area:release release.py, publish-pypi.yml, tag flow, PyPI area:rules Rule-engine plugins (Checkov, cdk-nag, discovery) area:sarif SARIF 2.1.0 output area:scanners Terraform / CDK scanners, filters, skip-list dependencies Runtime / dev dependency upgrade (Dependabot uses this name)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix project URLs in pyproject.toml (bishwasjha → alphacrack)

2 participants