Fix/fix pyproject urls - #68
Conversation
|
Thanks for jumping on this, @APK-hanal — and welcome! 🎉 Your actual change is exactly right: commit There's one thing blocking the merge, and it's not your edit — it's the base your branch was cut from. What's happeningYour branch started from How to fix it (2 minutes)# from your fork clone, on your branch:
git remote add upstream https://github.com/alphacrack/iac-scanner.git # skip if already added
git fetch upstream
git rebase upstream/main
# (your one commit replays cleanly on top of current main — the URL lines are unchanged there)
git push --force-with-leaseAfter that, this PR will show just One tiny thing to add while you're at it: put Really nice first contribution — this is a real bug that affects the PyPI project page, so thank you. Ping me here if the rebase gives you any trouble. 🙌 |
Signed-off-by: APK-hanal <apilkhanal10@gmail.com>
ed400aa to
a6f085d
Compare
|
@alphacrack Rebased onto the actual current main, Should just be Fix/fixpyproject urls +5-5 now, I added the Fix #46 as well to the description, Let me know if anything else is needed !! |
alphacrack
left a comment
There was a problem hiding this comment.
Rebased onto current main, diff is now exactly the 5 URL lines, CI green (20/20). Fixes #46. Thank you! 🎉
## Why Three first-time-contributor PRs open right now (#68, #69, #70) were all cut from a stale base and are unmergeable — because `CONTRIBUTING.md`, `CLAUDE.md`, and the PR template told them to branch from and target **`development`**, a branch frozen ~27 commits behind `main` since the v0.4.0 era. Everything actually ships from `main` (now protected). This PR fixes the misdirection. ## Changes - **CONTRIBUTING.md** — branch from / target `main`; add a one-time fork-sync snippet (`git remote add upstream … && git fetch upstream`) and a "if your PR shows dozens of files, rebase" troubleshooting note. - **PULL_REQUEST_TEMPLATE.md** — target `main`; the checklist now asks authors to confirm their branch is rebased on current `main` (diff shows only their files). - **CLAUDE.md** — state that `main` is the single trunk. ## Follow-up (separate, needs maintainer) Delete the `development` branch now that nothing points at it. Its 8 commits are old pre-squash v0.4.0 work already represented in `main`. ## Checklist - [x] Docs-only, no code/runtime change - [x] DCO signed - [x] Makes the review comments left on #68/#69/#70 accurate Fixes the root cause behind #68, #69, #70 base confusion. Signed-off-by: alphacrack <18480504+alphacrack@users.noreply.github.com>
Fixes #46
What & why
This change fixed the issue with project URL's in the pyproject.toml file.
Fixes #
Behavior change
How to review
About 5 lines changed in the 'pyproject.toml' file.
Test evidence
Manual verification -> Confirmed the URLs now match the repository's actual location.
Checklist
development(notmain).git commit -s).ruff check src/ tests/andruff format --check src/ tests/clean.mypy src/iac_scannerclean (CI is--strict).pytest tests/ -m "not e2e").[Unreleased]updated for user-visible behavior.orchestration/tasks.py:PROMPT_VERSIONbumped.SCHEMA_VERSIONincache.pybumped.Roll-out notes
None