Speed up tests by generating less CSV data #5759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can patch `max_rows` to trigger the same error with less data. This makes our tests run faster (previously this single test could take up to 5 seconds). We already take a similar approach for testing the normal CSV upload journey: https://github.com/alphagov/notifications-admin/blob/28feb377b5ff58784f33293f367464c107ad4657/tests/app/main/views/test_send.py#L4048-L4051
We only need to generate enough to show that what’s displayed on the page is capped at 512. Otherwise this is one of the slowest tests in our suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Improvement
1.51s, or 6% faster