Update "Add a service" page #5762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr8n3r
force-pushed
the
update-name-your-service-guidance
branch
from
7e536c1 to
f04f9e0
Compare
kr8n3r
changed the title
This updates content based on the content document (see Trello ticket) and makes the following markup changes: - removes conditional content from bullet points - adds h2 before `organisation_type` to bring the section into prominence - adds organisation_type form paramaters so that we can control the display of the legend (we want the form to have a legend, but as we have a h2 before it, we don;t need it to be visual) - adds a 'details' element with new content
'CreateNhsServiceForm' classes - Update the service name field label - Remove the form label from OrganisationTypeField class as we now control the legend text in the view.
Update tests that check for H1 text Remove the test that was testing conditional content in the bullet point examples, as they're no loneger present.
kr8n3r
force-pushed
the
update-name-your-service-guidance
branch
from
f04f9e0 to
d94db40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update the guidance on the ‘Add a new service’ screen.
Explicitly tell users that the service name is for us (Notify), and not for recipients.
Trello card
Changes include:
Why
In order to encourage users to choose a good service name (one which doesn’t cause problems when they request to go live), we need to change the name-your-service guidance.
Visuals
Before
After