Skip to content

PP-15376 session logout functionality#2026

Merged
hjvoid merged 1 commit into
masterfrom
PP-15376_passport_logout_functionality
May 27, 2026
Merged

PP-15376 session logout functionality#2026
hjvoid merged 1 commit into
masterfrom
PP-15376_passport_logout_functionality

Conversation

@hjvoid
Copy link
Copy Markdown
Contributor

@hjvoid hjvoid commented May 26, 2026

Amending clear session to a full logout.

  • This should logout users from Toolbox without logging them out of Github.
  • Changed the logout route to use POST instead of GET as per the Passport documentation.
  • Changed the anchor tag with an href to a form and button to facilitate a post request.
  • This PR will be reverted after staging as there will likely be some issues around the styling of the 'Sign out' button, at the moment we just want to know if the code works as expected in the test environment.
  • CodeQL is marking the POST route as missing rate limiting. These changes implement it via pay-js-commons but it looks like CodeQL isn't familiar with custom middleware. Nonetheless, this should be considered in reviewing.

Comment thread src/web/router.js Fixed
@hjvoid hjvoid force-pushed the PP-15376_passport_logout_functionality branch from 4add47b to 4c9071e Compare May 27, 2026 12:18
Comment thread src/web/router.js Fixed
@hjvoid hjvoid force-pushed the PP-15376_passport_logout_functionality branch from 4c9071e to c943698 Compare May 27, 2026 12:30
Comment thread src/web/router.js Dismissed
@hjvoid hjvoid force-pushed the PP-15376_passport_logout_functionality branch from c943698 to 2129a98 Compare May 27, 2026 13:44
@hjvoid hjvoid marked this pull request as ready for review May 27, 2026 14:00
Copy link
Copy Markdown
Contributor

@SandorArpa SandorArpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOKTM

@hjvoid hjvoid merged commit 3610c25 into master May 27, 2026
8 checks passed
@hjvoid hjvoid deleted the PP-15376_passport_logout_functionality branch May 27, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants