Conversation
Adds Tags.totalValueCount/truncated and a paginated ListTagValues RPC (following ListBillingGroupsPaginated's offset-pagination convention) so GetTags callers can cap per-key value lists and drill into a high- cardinality key on demand. Part of the tags-improvement Spanner migration (ripple-openspec optimize-tags-customer-index, task 4.1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tags.totalValueCount(int32) andTags.truncated(bool) soGetTagscan report per-key cardinality alongside a capped value list.ListTagValuesRPC (GET /v1/tags:values), offset-paginated followingListBillingGroupsPaginated's convention (pageNumber/pageSize), returning a page of a single(vendor, customerId, tagKey)'s distinct values plustotalValueCount/pageNumber/pageSize/totalPages.Part of the tags-improvement Spanner migration tracked in
ripple-openspec'soptimize-tags-customer-indexchange (task 4.1) — unblocks Ouchan'sbillingdread-path rewrite (fetchTags/GetTagscapping + drill-down) documented in that change'sdesign.md/specs/tag-retrieval/spec.md.Test plan
buf generateruns clean end-to-end (protoc-gen-go, protoc-gen-go-grpc, protoc-gen-grpc-gateway) with the submoduleprotosdependency initialized; newListTagValuesRequest/ListTagValuesResponse/Tags.TotalValueCount/Tags.Truncatedand theBilling_ListTagValuesgRPC client/server + gateway handler all generated correctly.go get github.com/alphauslabs/blue-sdk-go@<new tag>) once this merges and a newblue-sdk-gorelease is cut, to unblock thebillingdcapping/streaming rewrite.🤖 Generated with Claude Code