Add dive-count sort and favorites to the Add Buddy picker

.github/workflows/ci.yaml

@@ -416,6 +416,14 @@ jobs:
         # creating a new one and left it carrying the wrong build.
         run: ruby scripts/release/fastlane_submit_guard_test.rb
 
+      - name: Run App Review notes test
+        # Guards the committed App Review notes deliver uploads with every
+        # submission: present on both platforms, identical, within Apple's
+        # length limit, and free of other-platform names (2.3.10). iOS 1.7.4
+        # and 1.7.5 were rejected under 5.1.1(v) because nothing told the
+        # reviewer the app has no accounts.
+        run: ./scripts/release/app_review_notes_test.sh
+
       - name: Run pre-push hook test
         # Guards two hook bugs that both rejected pushes for reasons unrelated
         # to the change being pushed: running the checks against the main

.github/workflows/promote.yml

@@ -289,7 +289,8 @@ jobs:
           set -euo pipefail
           # Apple requires whatsNew on a new App Store version; deliver reads
           # it from metadata/en-US/release_notes.txt (the only metadata file
-          # we provide, so nothing else is touched).
+          # generated here; the committed review_information/notes.txt beside
+          # it is uploaded as-is and must not be touched).
           #
           # The GitHub release body is written for every platform at once, and
           # App Review guideline 2.3.10 forbids naming other platforms in App

android/app/src/main/AndroidManifest.xml

@@ -1,4 +1,13 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
+    <!--
+        Cloud sync, media upload, and the GitHub update check (#1258).
+        Release builds already carry this permission: the manifest merger
+        unions it in from a library manifest, and apkanalyzer confirms it in
+        the shipped v1.7.5.6772 APK. Declared here so it stops depending on
+        which plugins happen to be in the tree, since the only pub package
+        supplying it is google_sign_in_android, a transitive dependency.
+    -->
+    <uses-permission android:name="android.permission.INTERNET" />
     <!-- Biometric unlock for App Lock (local_auth) -->
     <uses-permission android:name="android.permission.USE_BIOMETRIC" />
     <!-- Photo library access for attaching dive photos -->

docs/developer/release-process.md

@@ -85,7 +85,16 @@ and the next merge to `main` starts the next beta train.
 Two things still want a human:
 
 - **A rejection.** Auto-release only covers the approved path. A rejected
-  version sits in App Store Connect until someone addresses it.
+  version sits in App Store Connect until someone addresses it. If the
+  rejection is a misunderstanding rather than a defect (1.7.4 and 1.7.5 were
+  both flagged under 5.1.1(v) because the first-launch "Create Your Profile"
+  step reads as account creation), reply in the Resolution Center thread and
+  do **not** re-run promote: the submission is still open, Apple approves
+  from the reply, and promote would cancel that submission and start over.
+  The standing explanation Apple reads before every review lives in
+  `ios/fastlane/metadata/review_information/notes.txt` (macOS has an
+  identical copy; `scripts/release/app_review_notes_test.sh` enforces
+  that). Update it whenever a reviewer needs context a reply had to supply.
 - **A bad build.** There is no staged rollout to halt and no rollback once a
   version is live. Recovering means pulling it and shipping a fix through
   another review cycle. If that risk ever outweighs the convenience, set