Realign the quic branch CI workflows with upstream - #23
Merged
Conversation
The quic branch commented out the schedule cron on the Main workflow under a CI-budget note, while apple/swift-nio-ssl main keeps it. Restoring it realigns the `on:` block with upstream, so the trigger no longer shows as a difference in the upstream proposal (apple#592). Scheduled workflows run from the repository's default branch. On this fork that is main, which already carries the trigger, so this is parity with upstream rather than new scheduled activity on quic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lo6DQFYJZY9HYuS6QTUpEr
The quic branch disabled the Linux nightly toolchains in the Unit tests workflow, while apple/swift-nio-ssl main runs them. The stated reason, that nightly rejects combining -warnings-as-errors/-Wwarning with -suppress-warnings, is already handled upstream: the nightly-main argument override drops -warnings-as-errors for exactly that reason, so nightly builds without the conflict. Restore the upstream nightly argument overrides so the Unit tests `with:` block matches upstream, removing the hunk from the upstream proposal (apple#592). Nightly stays informational: an upstream compiler bug can still turn it red, which is accepted. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lo6DQFYJZY9HYuS6QTUpEr
ydnar
changed the title
Author
|
Merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
The
quicbranch carries CI edits that diverge fromapple/swift-nio-sslmainfor reasons that no longer hold or are already handled upstream. Each divergence shows up as a workflow hunk in the upstream proposal (apple#592), unrelated to the QUIC-TLS API under review there.Modifications:
schedule:cron on theMainworkflow, matching upstream. Scheduled workflows run from the repository's default branch, which on this fork ismainand already carries the trigger, so this is parity rather than new scheduled activity onquic.Unit testsworkflow. The disable cited the nightly-warnings-as-errors/-suppress-warningsconflict, which upstream already avoids by dropping-warnings-as-errorsfrom thenightly-mainargument override. Restoring the upstream overrides runs nightly the same way upstream does.The
macos-test-forkjob and theapi_breakage_check_enabled: falseline stay, as fork CI plumbing the fork still needs: a fork has no access to Apple's self-hosted macOS runner pool, and there is no stable baseline for the API-breakage check yet.Result:
The
MainandUnit testsworkflow blocks onquicmatch upstream again, so the schedule and nightly hunks drop out of the upstream proposal (apple#592), leaving only the QUIC-TLS API plus the two intentional fork-CI differences. Nightly stays informational: an upstream compiler bug can still turn it red, which is accepted.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lo6DQFYJZY9HYuS6QTUpEr