Add Cohere CoreML ASR provider integration#244
Conversation
This reverts commit cb50098.
|
@codex can you fix it and run lint and formatting |
|
To use Codex here, create an environment for this repo. |
|
Updated summary note for reviewers:
The PR body should treat this as a qualified performance improvement, not a blanket speed claim for every machine or every short utterance. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e104859624
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| revision: spec.repositoryRevision, | ||
| requiredItems: spec.requiredEntries.map { .init(path: $0, isDirectory: $0.hasSuffix(".mlpackage")) } | ||
| ) | ||
| try await downloader.ensureModelsPresent(at: directory) { progress, item in |
There was a problem hiding this comment.
If artifact validation fails, this path retries with ensureModelsPresent, but that downloader only fills missing paths and does not overwrite existing files. In the common failure case where all required files exist but are incompatible/corrupted (for example a stale coreml_manifest.json or interrupted prior download), the subsequent validateArtifactsOrThrow will fail on every retry, so users cannot recover from the app and must manually delete cache files. Clearing/replacing managed artifacts before retrying would make download recovery reliable.
Useful? React with 👍 / 👎.
1 participant
Summary
Notes
mainmainalready contains the localhost auth fix from fix: #232 Update Authorization header logic for API requests #233