Debian package fix lintian errors #437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use header level 2 for sections. Specify shell as language for commands.
…ep libs Two libraries are added manually because they aren't detected by shlibs
Also replace deprecated pkg-config with pkgconf
august-alt
reviewed
Jul 27, 2024
The CMake has a built-in variable BUILD_TESTING (default ON) to compile tests. When building a debian package, the debhelper configures the CMake with this option OFF. So now we don't need to pass the DADMC_BUILD_DEB=ON and we can simplify the debian/rules
august-alt
reviewed
Aug 6, 2024
august-alt
reviewed
Aug 6, 2024
|
|
||
| add_subdirectory(src) | ||
| if(NOT ADMC_BUILD_DEB) | ||
| if(BUILD_TESTING) |
Collaborator
There was a problem hiding this comment.
If I recall correctly, the BUILD_TESTING variable is set up by CTest, which is not currently enabled in this project (see
https://cmake.org/cmake/help/latest/module/CTest.html
). Instead, we use the ADMC_BUILD_DEB variable, which is OFF by default. We need to consider one of three options: creating and setting a separate variable to explicitly enable or disable testing, setting ADMC_BUILD_DEB to ON by default, or completely refactoring the test setup.
Contributor
Author
There was a problem hiding this comment.
If the BUILD_TESTING not declared then the if will be ignored. This is typical usage as far I saw from other repos.
Samael-fhts
force-pushed
the
master
branch
2 times, most recently
from
fea801a to
af5e590
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kvvloten please review.
The set cmake_minimum_required to 3.5 I made to fix a deprecation warning.
Now we have two ways to build a deb package: the standard
debuildand themake packageto build the deb package directly from the cmake with CPack. I found this confusing and unless the CPack is really used I would propose to remove it.UPD fixed in 468dcc8 Another problem is that tests are included by default unless the
ADMC_BUILD_DEBvar is not set. Because of this we have to specify theADMC_BUILD_DEBin thedebian/rulesfile.Maybe the test should be implemented with the CMake add_test or something like that to make it more standard. The the debhelper will just skip the tests in the convenient way.