Replace deprecated Redis commands, bump to 1.0.0 - #6
Merged
Conversation
rpoplpush/brpoplpush were deprecated in Redis 6.2 in favour of lmove/blmove. Also add frozen_string_literal, remove unused size attr_reader, and use lrem count 1 instead of 0 since each item appears exactly once in the working queue.
epaune-alt
requested changes
Mar 30, 2026
epaune-alt
left a comment
epaune-alt
left a comment
There was a problem hiding this comment.
I think that we should add to the README that the minimum version of Redis for version 1.0 is 6.2
epaune-alt
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deprecated rpoplpush/brpoplpush with lmove/blmove, which were introduced in Redis 6.2. This is a breaking change for users on Redis < 6.2, hence the major version bump to 1.0.0.
Additional improvements:
sizeattr_reader from ChunkedReliableQueue