Fix connection overlay sometime not showing + Queue updates to tracker when disconnected - #32
Open
Jouramie wants to merge 4 commits into
Open
Conversation
Jouramie
added a commit
to Jouramie/TheMessengerRandomizerModAP
that referenced
this pull request
Aug 1, 2026
…r when disconnected (alwaysintreble#32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback from https://discord.com/channels/731205301247803413/1090822939697500243/1532474440217268395
It seems like sometimes, the mod does not send updates to the tracker. My best guess is that player was disconnected from the server, but was not aware of it.
The overlay telling players they're connected is currently bugged. When the mod first connect, the overlay does not show. It only gets its first update after messages are received from the server. I noticed that while testing/playing solo seeds, it can take a long time for it to show up. That would explain how players are not aware their mod is disconnected. In this specific case, they were in a room with only one other player, so not much server chatting.
So this fixes the overlay, now it will also update when the client connect/disconnect. The
TrackerManagerwill also keep a statea state of the updates that could not be sent while the client was disconnected, so they can be sent when the client reconnects.Last thing, I moved
UpdateArchipelagoStateintoAPRandomizerMaininstead of it being inArchipelagoClient.ArchipelagoClientis currently the center of the spaghetti the mod is. Everything talks to it, and it talks to everything. My goal with the change is to eventually only have stuff talking to the client, and the client talking to mostly nothing (only external stuff like theArchipelagoSession,DeathLinkInterface, etc). The client in itself can't do much anyway since Unity is single-threaded. It can only queue stuff and wait for the update to pick it up.