feat: updater circle uses rss_link + HTTP ETag, skips empty channels - #9
Merged
Conversation
kinton
marked this pull request as ready for review
September 3, 2026 10:20
Add channels.http_etag and http_last_modified, create them on connect if the hand-applied migration has not run yet, and skip channels that have nobody to notify (notify=1 on a live user, or an active tg-channel). Co-authored-by: Kovalenko K. <kintonkk@gmail.com>
The scheduled circle uses our stored rss_link plus If-None-Match / If-Modified-Since. HTTP 304 is not parsed, not a feed failure, and does not sleep 6s. iTunes lookup stays the fallback when rss_link is empty and for the manual update button / search UI. Co-authored-by: Kovalenko K. <kintonkk@gmail.com>
Temp-file DBs and mocked HTTP only. 304 is not treated as ok-content, unchanged feeds are not parsed, and channels without live notify recipients are skipped. Co-authored-by: Kovalenko K. <kintonkk@gmail.com>
cursor
Bot
force-pushed
the
cursor/updater-etag-circle-d56e
branch
from
September 3, 2026 15:39
a6329df to
e0f5b77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The scheduled updater circle uses our
channels.rss_linkplus HTTP ETag / Last-Modified. Unchanged feeds return 304 and are not downloaded or parsed. Channels with nobody to notify are skipped (nosleep(6)).Behavior
Response.okis true for 304). No XML parse, not gone/unavailable, does not increment feed-failure counters (failures are reset: the feed is reachable).http_etag/http_last_modifiedon the channel row (created on SQLighter connect and indb/migrations/00012_channel_http_validators.py).manual=False):rss_link+ stored validators. iTunes lookup only ifrss_linkis empty.notify=1user (deleted_at IS NULL, paid or not) or an active tg-channel connection. Empty channels are not slept on. 6s delay remains after a real body download.Left alone
iTunes search/UI. Outbox. Bot API polling (PR #5). Start/deploy still
python main.py/supervisorctl restart yourcast.Tests
python db/test_channel_poll.pyandvenv/bin/python app/service/podcast/test_feed_etag.py— temp DBs and mocked HTTP only.