v1.17.1 — codex_approval pattern + stuck-detector coverage doc#54
Merged
Conversation
v1.17.0 shipped the detector with one approval-modal pattern keyed on
Claude Code's "Do you want to proceed?" wording. Antigravity happens to
use the same phrase, so it was already covered, but Codex uses a
different opening ("Would you like to run the following command?") and
was silently missed.
Add a second approval pattern, `codex_approval`, with the Codex-specific
regex. Keep `claude_approval` as the existing id (it also matches agy,
which we now document).
Update the minimum-headroom-ops skill with a coverage table that lists
every shipping pattern, which CLI it matches, and what is intentionally
left out — so operators know when to extend `DEFAULT_STUCK_PATTERNS`
versus when to fall back to `agent.pane_snapshot` directly.
Tests:
- New: codex_approval pattern matches the Codex shell-command approval
modal (sample taken from a real codex pane).
- New: claude_approval also catches the Antigravity permission modal
(documents the existing behavior).
- Updated: DEFAULT_STUCK_PATTERNS id list now includes codex_approval.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Patch release for the codex_approval pattern addition. Six sites move together: package.json, mcp-server/dist/index.js SERVER_VERSION, tts-worker/pyproject.toml, asr-worker/pyproject.toml, and both uv.lock files (refreshed via `uv lock`). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex_approvalregex toDEFAULT_STUCK_PATTERNSfor Codex's"Would you like to run the following command?" shell-approval modal.
v1.17.0 only caught Claude's "Do you want to proceed?" wording; that
also covers Antigravity (same phrase) but missed Codex entirely.
what is intentionally not caught) in the minimum-headroom-ops skill.
Test plan
npm test— 359/359 pass locally (2 new tests added).🤖 Generated with Claude Code