feat: Add properties to Device and Emulator#1320
Merged
Merged
Conversation
Both of the main implementations of `Device`, namely `AwsDevice` and `LocalSimulator`, have a `properties` property that doesn't, but should exist in the parent class. This change codifies this property, and gives emulators the capabilities of the emulated device.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 171 171
Lines 11489 11497 +8
Branches 1499 1499
=========================================
+ Hits 11489 11497 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5 tasks
Contributor
|
🙌 @speller26 this fixes some other random issues I've had T.T. Can properly direct emulator properties in the QBP as well. |
rmshaffer
reviewed
Jul 10, 2026
Comment on lines
72
to
73
| if isinstance(device_properties, DeviceEmulatorProperties): | ||
| device_em_properties = device_properties |
Member
There was a problem hiding this comment.
just to double-check - it's intentional that you don't (can't) set device_capabilities in this branch, correct?
Member
Author
There was a problem hiding this comment.
Yes, because DeviceEmulatorProperties does not subclass DeviceCapabilities, and setting it in this branch would produce unexpected results when interacting with .properties.
rmshaffer
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of the main implementations of
Device, namelyAwsDeviceandLocalSimulator, have apropertiesproperty that doesn't, but should exist in the parent class. This change codifies this property, and gives emulators the capabilities of the emulated device.Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.