Fix Chronos-2 fine-tuning to preserve loaded GPU device index#471
Open
dario-fumarola wants to merge 1 commit intoamazon-science:mainfrom
Open
Fix Chronos-2 fine-tuning to preserve loaded GPU device index#471dario-fumarola wants to merge 1 commit intoamazon-science:mainfrom
dario-fumarola wants to merge 1 commit intoamazon-science:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Chronos2Trainer._move_model_to_deviceto preserve the model's existing CUDA device when the model is already loaded on a specific GPU and nohf_device_mapis settransformers.Trainerfrom moving a model loaded on e.g.cuda:5back tocuda:0Why
Issue #457 reports that Chronos-2 fine-tuning fails when the model is loaded on a non-zero GPU index because the default Trainer move logic forces the model onto
cuda:0.Validation
uv run --python 3.11 python -m pytest test/test_chronos2_trainer.pyuv run --python 3.11 python -m pytest test/test_chronos2.py -k "pipeline_can_be_finetuned or two_step_finetuning_with_df_input_works"uv run --python 3.11 mypy src testFixes #457