Checking if legend destroy exists before clearing a chart on unmount#78
Open
shivangkumar wants to merge 1 commit into
Open
Checking if legend destroy exists before clearing a chart on unmount#78shivangkumar wants to merge 1 commit into
shivangkumar wants to merge 1 commit into
Conversation
Collaborator
|
@shivangkumar Thanks a lot for that! However, I don't think it's quite correct. Charts aren't required to have a I'll need to discuss this with the team to figure out the best way to fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When component unmounts before chart is completely rendered, in some race scenarios the legend object does not contain the destroy method and thus fails. This commit helps prevent the unmounting from breaking.