Skip to content

chore(skills): disable squash merge in setup-repo#76

Merged
amcheste merged 1 commit intodevelopfrom
chore/setup-repo-disable-squash
Apr 26, 2026
Merged

chore(skills): disable squash merge in setup-repo#76
amcheste merged 1 commit intodevelopfrom
chore/setup-repo-disable-squash

Conversation

@amcheste-ai-agent
Copy link
Copy Markdown

Summary

Adds Step 3 to setup-repo: disable squash merging at the repo level, set rebase as the default merge style, keep merge commits enabled as a fallback for ceremonial merges (e.g. CLI --no-ff develop → main releases).

Why

Squash-merging PRs silently:

  1. Replaces the bot's primary authorship with the merger
  2. Drops the Co-Authored-By: amcheste trailers entirely

That happened today on pokemon-red-ai#25 and #26: the squash commits ended up authored by amcheste-ai-agent[bot] (the App identity, not the bot user account), with no co-author trailers, and @amcheste got zero contribution-graph credit.

Rebase merge preserves per-commit authorship and trailers, so each bot commit lands on the default branch with @amcheste as a structurally-recognized co-author (verified via GraphQL Commit.authors).

The skill update closes the gap on new repos. Existing repos (15 amcheste/* + 3 amcheste-ai-agent/*) were already updated out-of-band via direct PATCH calls.

Changes

  • New Step 3: Set merge policy: disable squash, default to rebase
  • Old Steps 4/5/6 renumbered to 5/6/7
  • Summary block updated to surface the merge-policy line

Test plan

  • SKILL.md renders correctly
  • Run /setup-repo against a new test repo and confirm the merge settings are applied

Related

  • engineering-handbook docs/philosophies/merge-strategy.md — the philosophy doc that motivates this rule (separate PR coming)

Adds Step 3: PATCH the repo to set allow_squash_merge=false,
allow_rebase_merge=true, allow_merge_commit=true.

Squash-merge silently drops Co-Authored-By trailers and replaces
the bot primary authorship with the merger. Today, that erased
amcheste co-author credit on PRs #25 and #26 in pokemon-red-ai
and put amcheste-ai-agent[bot] (the App identity, not the bot
user account) as sole author of the squash commits. The skill
update prevents the wrong button from being clickable on any
new repo.

Existing repos were updated out-of-band via direct PATCH calls
(15 amcheste/* + 3 amcheste-ai-agent/*).

Step numbering: old Steps 4/5/6 shift to 5/6/7. Summary updated
to surface the merge-policy line.

Refs: docs/philosophies/merge-strategy.md (handbook, pending PR)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: amcheste <13696614+amcheste@users.noreply.github.com>
@amcheste-ai-agent amcheste-ai-agent Bot requested a review from amcheste as a code owner April 26, 2026 02:43
Copy link
Copy Markdown
Owner

amcheste commented Apr 26, 2026

Merge activity

  • Apr 26, 2:51 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Apr 26, 2:52 AM UTC: @amcheste merged this pull request with Graphite.

@amcheste amcheste merged commit 12e5d33 into develop Apr 26, 2026
7 checks passed
@amcheste amcheste deleted the chore/setup-repo-disable-squash branch April 26, 2026 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants