serving-llms-on-epyc skill - address feedback - #215
Open
amd-lalithnc wants to merge 1 commit into
Open
amd-lalithnc wants to merge 1 commit into
amd-lalithnc wants to merge 1 commit into
Conversation
- Hard-gate AVX-512 in validate.py (blocking error / ready:false), so pre-Zen4 EPYC stops before the image pull instead of failing at model load. Enforces the Step 1 gate programmatically, not just in prose. - Resolve the HF cache mount in validate.py: follow symlinks, flag NFS/root-squash, and return the real -v mount to use (the ~/.cache/huggingface default breaks on NFS homes). - Add --cap-add=SYS_NICE so NUMA memory binding works in the container (else it silently fails with 'Operation not permitted'). - Add free-port guidance for --network=host (a busy port is a hard failure). Signed-off-by: Lalithnarayan C <Lalithnarayan.C@amd.com> Change-Id: Idc30ae70dbf709008a90bb215eeb66f29d5edfea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change-Id: Idc30ae70dbf709008a90bb215eeb66f29d5edfea