This repository was archived by the owner on Jul 2, 2020. It is now read-only.
Limit mapping fields to count of available CF7 forms#15
Open
felipeelia wants to merge 1 commit intoamimoto-ami:masterfrom
Open
Limit mapping fields to count of available CF7 forms#15felipeelia wants to merge 1 commit intoamimoto-ami:masterfrom
felipeelia wants to merge 1 commit intoamimoto-ami:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Currently it's only possible to map 5 forms. This PR makes possible mapping all available forms.
This PR solves an immediate problem, but IMO, the select boxes aren't the ideal solution. We should have a list of all CF7 forms with a list of input fields, with names as
name='cf7_mautic_settings[form_id][{$post_id}]'or something like that. What do you think? If you agree with that I can change the necessary code. The only problem would be backward compatibility, as it would change the current behavior of using a bidimensional array and array_search to find the id of given post_id.Steps to test this PR:
As we do have just a 1:1 relation, I think we should make possible to user map all forms.