This repository was archived by the owner on Jul 2, 2020. It is now read-only.
Update class.submit.php - user IP problem issue [amimoto-ami#2]#17
Open
qasimk2 wants to merge 1 commit intoamimoto-ami:masterfrom
Open
Update class.submit.php - user IP problem issue [amimoto-ami#2]#17qasimk2 wants to merge 1 commit intoamimoto-ami:masterfrom
qasimk2 wants to merge 1 commit intoamimoto-ami:masterfrom
Conversation
Solves the user IP problem issue [amimoto-ami#2]. 'REMOTE_ADDR' is populated each time but holds the server address. 'HTTP_X_FORWARDED_FOR' holds the client address. The foreach loop at line 165 finds the REMOTE_ADDR and the quits the loop therefore 'HTTP_X_FORWARDED_FOR' is never sent. This has been tested and is working in production for us. Qasim onewood.co
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves the user IP problem issue [#2].
'REMOTE_ADDR' is populated each time but holds the server address. 'HTTP_X_FORWARDED_FOR' holds the client address.
The foreach loop at line 165 finds the REMOTE_ADDR and the quits the loop therefore 'HTTP_X_FORWARDED_FOR' is never sent.
This has been tested and is working in production for us.
Qasim
onewood.co
Description:
Steps to test this PR:
Steps to reproduce the bug:
List deprecations along with the new alternative:
List backwards compatibility breaks: