done#385
Merged
Merged
Conversation
|
@johdanike Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR addresses technical debt by removing static mock data references and introduces a comprehensive test suite for the dispute management React Query hooks.
Closes #347: Remove Mock Data and Integrate Real API Data
Closes #203: [Frontend · Dispute system UI] Write dispute hook tests
What changed
Mock Data Cleanup (Title: Remove Mock Data and Integrate Real API Data #347)
src/components/approval/ApprovalExpiryCountdown.tsxandsrc/components/approval/ApprovalStatusWidget.tsx.Dispute Hook Tests ([Frontend · Dispute system UI] Write dispute hook tests #203)
src/hooks/__tests__/useDisputeHooks.test.tsx.useMutateRaiseDisputesuccessfully callsPOST /disputesand triggers a success toast.useMutateResolveDisputecallsPATCH /disputes/:idand triggers query invalidation on success.useMyDisputesreturns the expected scoped data structure.src/hooks/__tests__/useDisputeDetail.test.tsxto verifyisNotFoundhandling for 404 responses.Why this matters
Removing static mock data ensures the frontend relies entirely on real backend-driven data for accurate real-world functionality. The new unit tests for the dispute system provide confidence in the API integration, ensuring that raising and resolving disputes correctly manage server state and UI feedback.
Testing
Run the dispute hook test suite:
Also validate polling hook integration:
Notes
usePollinghook andapiClientinfrastructure for consistency.